Conversation
ref https://linear.app/ghost/issue/BER-3333/port-members-list-from-ember-to-react Ported our Members list from Ember to React. Currently on a different path and behind the membersForward flag. Includes filtering updates made on the Comments page.
#26465) no issue ## Summary - Refactored `completeStripeSubscription` to poll the Members API (`/members/api/member/`) until the member has `paid` status, replacing the unreliable `waitForLoadState('networkidle')` which returned before the Stripe webhook was processed - Extracted `submitStripePayment` helper for non-subscription checkouts (donations) where the member won't become paid - Removed hardcoded `{timeout: 30000}` from upgrade test assertions since the webhook is now confirmed processed before Portal is opened
no issue - Updated the hardcoded Stripe test card expiry from `04 / 26` to `12 / 30` in browser test utils - The old date (April 2026) is about to expire, which would cause Stripe to reject the test card and fail CI browser tests
ref https://linear.app/ghost/issue/NY-971/post-ga-cleanup-remove-the-welcomeemails-labs-flag-from-admin There should be no behavioral changes in this commit, since the `welcomeEmails` flag has already been promoted to GA. Now that welcome emails are in GA, we want to remove the flag completely. This commit removes any conditional behavior in Ghost/core's Stripe service that depends on the `welcomeEmails` flag.
ref https://linear.app/ghost/issue/NY-971/post-ga-cleanup-remove-the-welcomeemails-labs-flag-from-admin There should be no behavioral changes in this commit, since the `welcomeEmails` flag has already been promoted to GA. Now that welcome emails are in GA, we want to remove the flag completely. This commit removes any conditional behavior in the admin-x-settings app that depends on the `welcomeEmails` flag.
ref https://linear.app/ghost/issue/BER-3295 Adds `subscription.offer_redemptions` (sourced from offer_redemptions table) to the member API response, and updates admin to display all historical offers on the member page instead of only the current active offer. This is to support retention offers where the system now has to account for multiple offer redemptions potentially occurring on the same sub
ref https://linear.app/ghost/issue/NY-971/post-ga-cleanup-remove-the-welcomeemails-labs-flag-from-admin There should be no behavioral changes in this commit, since the `welcomeEmails` flag has already been promoted to GA. Now that welcome emails are in GA, we want to remove the flag completely. This commit removes any conditional behavior in Ghost/core's Outbox processing job that depends on the `welcomeEmails` flag.
no ref This change should have no user impact. While I was working on something else, I noticed these classes which are unused. Let's remove them.
…26449) closes https://linear.app/ghost/issue/NY-1050 On iOS, we have four options for Inbox Links: 1. Don't show them at all. 2. Open the email inbox in the browser (a regular link). 3. Try to open the associated email app. If it's installed, great. If it's not, nothing will happen. (Kind of a bad experience.) 4. Try to open the associated email app. If it's installed, great. If the user taps it and nothing happens, wait 1 second and then do something else. (Not a great option either for several reasons.) Previously, we did option 2. Now we do option 1.
This test-only change should have no user impact. This replaces the following Should.js assertions with `node:assert`: - `.should.not.eql` - `.should.matchAny` - `.should.be.an.Object()`
…26383) ref https://linear.app/ghost/issue/BER-3295 The `offer_id` column previously persisted forever, even after the Stripe discount expired. This changes the sync guard to only preserve `offer_id` for active trials, and broadens the `OfferRedemptionEvent` trigger to fire on any offer_id change (not just `null` → `new`), enabling retention offer redemption tracking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )